----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51157/#review145956 -----------------------------------------------------------
Patch looks great! Reviews applied: [50907, 50910, 50912, 51008, 51108, 51109, 51110, 51111, 51113, 51127, 51145, 51146, 51157] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 16, 2016, 11:15 p.m., Haris Choudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51157/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 11:15 p.m.) > > > Review request for mesos, Joseph Wu and Kevin Klues. > > > Bugs: mesos-5676 > https://issues.apache.org/jira/browse/mesos-5676 > > > Repository: mesos > > > Description > ------- > > While introducing testing for the container plugin, some changes > were made to the plugin methods themselves mainly to allow the return > of stdout by methods that make use of nsenter is some way. > > > Diffs > ----- > > src/cli_new/bin/tests.py PRE-CREATION > src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION > src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION > > Diff: https://reviews.apache.org/r/51157/diff/ > > > Testing > ------- > > ![Tested on Ubuntu 14.04](http://i.imgur.com/Wo30SBw.png) > > > Thanks, > > Haris Choudhary > >