> On Aug. 17, 2016, 7:55 p.m., Jiang Yan Xu wrote: > > Mind adding a test? We already have > > `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Get` but we can add another > > `ROOT_CGROUPS_Nonresursive_Get` and change the current one into a > > `ROOT_CGROUPS_Recursive_Get`. > > > > The argument `bool recursive` defaults to true today because it's the > > current behavior. However I am not sure if we actually want this as the > > default. This is another disucssion to have but as least let's make the > > tests explicit, i.e., `ROOT_CGROUPS_Nonresursive_Get` and > > `ROOT_CGROUPS_Recursive_Get` for now.
I think we could change the default value to `false` which match the default value in `cgroups::create`. And update `cgroups::get` to use `recursive=true` in `cgroups::remove` and `cgroups::destroy`. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review146028 ----------------------------------------------------------- On Aug. 17, 2016, 5:38 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 5:38 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > Added non-recursive version of `cgroups::get`. > > > Diffs > ----- > > src/linux/cgroups.hpp 047d3ea596660e704447c0f0c7b914a43c4a2187 > src/linux/cgroups.cpp f3232c009d04bb82701c0407b12abf999ab60a73 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
