----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/#review146147 -----------------------------------------------------------
Looking at what runC does: https://github.com/opencontainers/runc/blob/master/libcontainer/init_linux.go#L119-L144 This sounds pretty clean, why we need such a helper method? - Jie Yu On Aug. 12, 2016, 4:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51042/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 4:49 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/capabilities.hpp fd7a571a62e3bbdd8a0453f800bf622457891bf8 > src/linux/capabilities.cpp 5f21dd42dd94af907450aabb1900d1f73816b31c > > Diff: https://reviews.apache.org/r/51042/diff/ > > > Testing > ------- > > make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
