----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51099/#review146236 -----------------------------------------------------------
Ship it! Ship It! - Neil Conway On Aug. 16, 2016, 4:34 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51099/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 4:34 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-5875 > https://issues.apache.org/jira/browse/MESOS-5875 > > > Repository: mesos > > > Description > ------- > > Also clarified in the comments that when we say "We discard any additional > precision" we mean the fractional part. > > > Diffs > ----- > > src/common/values.cpp cc87d9436f1a75e71cbeb8b709ec323e24f4f519 > src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b > src/v1/values.cpp 6e3617ef8cce1b89632d9266878914e472e069b1 > > Diff: https://reviews.apache.org/r/51099/diff/ > > > Testing > ------- > > make check. > > Added a test block which would fail without the change. > > > Thanks, > > Jiang Yan Xu > >
