Re: Review Request 51097: Added a `PortMapper` class.

[Avinash sridharan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51097/
-----------------------------------------------------------

(Updated Aug. 22, 2016, 3:50 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
-------

Fixed some indentation.


Bugs: MESOS-6023
    https://issues.apache.org/jira/browse/MESOS-6023


Repository: mesos


Description
-------

This class will embody the logic for implementing the CNI port-mapper
plugin.


Diffs (updated)
-----

  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp
 PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp
 PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51097/diff/


Testing
-------

Tested the port-mapper with the following CNI config:
{
    "name": "mynet",
    "type": "port-mapper",
    "chain": "MESOS",
    "delegate": {
      "type" : "bridge",
      "bridge": "cni0",
      "isGateway": true,
      "ipMasq": true,
      "ipam": {
          "type": "host-local",
          "subnet": "10.22.0.0/16",
          "routes": [
            { "dst": "0.0.0.0/0" }
          ]
      }
    },
    "args" : {
      "org.apache.mesos" : {
        "network_info" : {
          "port_mappings": {
            "host_port" : 80,
            "container_port" : 80
          }
        }
      }
    }
}

and the following environment variables:
export CNI_COMMAND="ADD"
export CNI_CONTAINERID="0000000111101110"
export CNI_PATH="$MESOS_INSTALL:/home/vagrant/dev/go/cni/bin"
export CNI_IFNAME="eth0"
export CNI_NETNS="/etc/netns"

If we remove fields from the above CNI config, or remove certain environment 
variables the creation of the `PortMapper` correctly fails. However, if config 
and environment variables are passed as is it will create the `PortMapper` 
correctly.


Thanks,

Avinash sridharan