----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146398 -----------------------------------------------------------
Note: Your summary/description says `execlp`, but the code is for `execvp` :P 3rdparty/stout/include/stout/os/windows/shell.hpp (lines 114 - 115) <https://reviews.apache.org/r/51217/#comment212806> I'm not sure I understand what this comment is saying. Are you explaining the reason behind the `exit(...)`? - Joseph Wu On Aug. 19, 2016, 10:38 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51217/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2016, 10:38 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added `os::execlp' in `stout` library. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/shell.hpp > 1d73ae5fa7182ba433eaee0cc0034af6b36d77db > 3rdparty/stout/include/stout/os/windows/shell.hpp > c6e141aba0abe2c7fe5410e867f7db47d632e765 > > Diff: https://reviews.apache.org/r/51217/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
