----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ -----------------------------------------------------------
(Updated Sept. 3, 2016, 6:05 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus Ma, and Jiang Yan Xu. Bugs: MESOS-3157 https://issues.apache.org/jira/browse/MESOS-3157 Repository: mesos Description (updated) ------- - Triggered allocations dispatch allocate() only if there is no pending allocation in the queue. - Allocation candidates are accumulated and only cleared when enqueued allocations are processed. - Batched allocations are handled synchronously. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp dd07ed221d2c1755d2478369641ffdc46ecc4471 src/master/allocator/mesos/hierarchical.cpp 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4 Diff: https://reviews.apache.org/r/51027/diff/ Testing ------- make check note: check without filters depends on https://reviews.apache.org/r/51028 With new benchmark https://reviews.apache.org/r/49617: Sample output without 51027: [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22 Using 10000 agents and 3000 frameworks Added 3000 frameworks in 57251us Added 10000 agents in 3.21345353333333mins allocator settled after 1.61236038333333mins [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22 (290578 ms) Sample output with 51027: [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22 Using 10000 agents and 3000 frameworks Added 3000 frameworks in 39817us Added 10000 agents in 3.22860541666667mins allocator settled after 25.525654secs [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22 (220137 ms) Thanks, Jacob Janco