> On Sept. 4, 2016, 7:13 a.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 372-373 > > <https://reviews.apache.org/r/51420/diff/2/?file=1488232#file1488232line372> > > > > Just nit, I saw that the recover case is using > > `UUID::random().toString()` to set the id while some using hard code ids, > > it is better make them consistent in code.
Fixed. thx. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/#review147738 ----------------------------------------------------------- On Sept. 7, 2016, 11:49 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51420/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 11:49 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added provisioner appc unit test for provisioning nested container. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/51420/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
