----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51707/#review148121 -----------------------------------------------------------
Bad patch! Reviews applied: [51707, 51653, 51706, 51021, 51377, 51376, 51375, 51374, 51371, 51020, 50846, 50845, 50844, 50707, 50706, 50705, 50704, 50703, 50702, 50701, 50700, 50699, 50422, 50418, 50417, 50416, 50235] Failed command: ./support/apply-review.sh -n -r 51374 Error: 2016-09-08 00:37:00 URL:https://reviews.apache.org/r/51374/diff/raw/ [21014/21014] -> "51374.patch" [1] error: patch failed: src/master/master.cpp:1752 error: src/master/master.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15152/console - Mesos ReviewBot On Sept. 7, 2016, 9:36 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51707/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 9:36 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5965 > https://issues.apache.org/jira/browse/MESOS-5965 > > > Repository: mesos > > > Description > ------- > > Now that we update the registry before updating the master's state when > performing these transitions, it is possible for the master to already > be marking a slave unreachable when an `UnregisterSlaveMessage` is > received, or vice versa. Detect these situations and ignore whichever > transition is triggered second. > > > Diffs > ----- > > src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 > src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 > > Diff: https://reviews.apache.org/r/51707/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
