> On 九月 7, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3427-3428 > > <https://reviews.apache.org/r/50695/diff/2-3/?file=1460378#file1460378line3427> > > > > This looks alright. Why is it removed?
I added this back, thanks Jiang Yan. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/#review148016 ----------------------------------------------------------- On 九月 8, 2016, 2:04 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50695/ > ----------------------------------------------------------- > > (Updated 九月 8, 2016, 2:04 a.m.) > > > Review request for mesos, Benjamin Mahler, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Renamed agent used resources to `allocation` for benchmark test. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > b2179215f3a4c2f4018670e8e54f02e06c39c3b1 > > Diff: https://reviews.apache.org/r/50695/diff/ > > > Testing > ------- > > make > make check > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 911us > Added 1000 agents in 1.014938secs > Updated 1000 agents in 603347us > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > (1683 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (1683 ms total) > ``` > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 861us > Added 1000 agents in 1.487206secs > round 0 allocate() took 808744us to make 0 offers after filtering 1000 offers > round 1 allocate() took 825291us to make 0 offers after filtering 1000 offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > (6126 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (6126 ms total) > ``` > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 998us > Added 1000 agents in 1.934967secs > round 0 allocate() took 810760us to make 0 offers after filtering 1000 offers > round 1 allocate() took 814886us to make 0 offers after filtering 1000 offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > (6747 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (6747 ms total) > ``` > > > Thanks, > > Guangya Liu > >
