----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/#review148500 -----------------------------------------------------------
Bad patch! Reviews applied: [51805, 51707, 51653, 51706, 51021, 51377, 51376, 51375, 51374, 51371, 51020, 50846, 50845, 50844, 50707, 50706, 50705, 50704, 50703, 50702, 50701, 50700, 50699, 50422, 50418, 50417, 50416, 50235] Failed command: ./support/apply-review.sh -n -r 51805 Error: 2016-09-12 15:36:28 URL:https://reviews.apache.org/r/51805/diff/raw/ [13352/13352] -> "51805.patch" [1] error: patch failed: src/tests/partition_tests.cpp:1589 error: src/tests/partition_tests.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15216/console - Mesos ReviewBot On Sept. 12, 2016, 1:17 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51805/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 1:17 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > When a task launched by a partition-aware framework is running on an > agent that becomes partitioned from the master, the framework will now > receive TASK_UNREACHABLE, not TASK_LOST. > > Similarly, when a partition-aware framework does explicit reconciliation > for an agent ID that appears in the "unreachable" list in the registry, > the master will now return TASK_UNREACHABLE rather than TASK_LOST. > > > Diffs > ----- > > src/master/master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2 > > Diff: https://reviews.apache.org/r/51805/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Neil Conway > >
