> On Sept. 5, 2016, 1:51 p.m., Vinod Kone wrote: > > src/slave/http.cpp, line 1454 > > <https://reviews.apache.org/r/51626/diff/2/?file=1490881#file1490881line1454> > > > > it's a bit weird that `getState` filters frameworks, executors but not > > containers. > > > > can you filter `getContainers` based on frameworksApprover and > > executorsApprover? that should probably be the very first review of this > > chain.
Address at https://reviews.apache.org/r/51625/ - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51626/#review147759 ----------------------------------------------------------- On Sept. 12, 2016, 4:51 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51626/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 4:51 p.m.) > > > Review request for mesos, Anand Mazumdar, Jay Guo, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-6124 > https://issues.apache.org/jira/browse/MESOS-6124 > > > Repository: mesos > > > Description > ------- > > Showed the containers information in the v1 `GET_STATE` API of Agent. > > > Diffs > ----- > > include/mesos/agent/agent.proto 5b91677487f8e23301e67af14c2115c6b4a533ac > include/mesos/v1/agent/agent.proto 8145669073553dc8aa56cfe2c0a0b756d70fee0e > src/slave/http.cpp 2cbf3c57e294f0d47d64915371b4a6bbf9cdfc0a > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb > > Diff: https://reviews.apache.org/r/51626/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*AgentAPITest*" --verbose > [ OK ] ContentType/AgentAPITest.GetAgent/1 (37 ms) > [----------] 32 tests from ContentType/AgentAPITest (11079 ms total) > > [----------] Global test environment tear-down > [==========] 32 tests from 1 test case ran. (11102 ms total) > [ PASSED ] 32 tests. > ``` > > > Thanks, > > haosdent huang > >
