----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148575 -----------------------------------------------------------
Fix it, then Ship it! LGTM modulo comments from me and Guangya. src/master/validation.cpp (lines 1020 - 1021) <https://reviews.apache.org/r/51771/#comment216034> ``` return Error("Docker ContainerInfo is not supported"); ``` src/master/validation.cpp (lines 1084 - 1085) <https://reviews.apache.org/r/51771/#comment216035> see above. just s/task/executor/ - Vinod Kone On Sept. 9, 2016, 8:21 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51771/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 8:21 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6144 > https://issues.apache.org/jira/browse/MESOS-6144 > > > Repository: mesos > > > Description > ------- > > DOCKER as ContainerInfo Type for both task group executor as well as > taskgroup task is currently not supported. Only MESOS as > ContainerInfo Type is supported. This patch is to validate that > TaskGroup executor and tasks do not use DOCKER ContainerInfo. > > > Diffs > ----- > > src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 > src/tests/master_validation_tests.cpp > 3a5cfa2b8a500c1c9e8af5207ebb91279a61feed > > Diff: https://reviews.apache.org/r/51771/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo make -j`nproc` check > > > Thanks, > > Abhishek Dasgupta > >
