----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148537 -----------------------------------------------------------
CHANGELOG (line 28) <https://reviews.apache.org/r/51560/#comment215983> "from now on" is not accurate anymore right? If deprecation of the feature is starting in 2.0, from now on and until 2.0, it's a valid and supported usage. docs/upgrades.md (line 50) <https://reviews.apache.org/r/51560/#comment216161> See comment below. docs/upgrades.md (line 209) <https://reviews.apache.org/r/51560/#comment216160> Using health checks without setting the type is **not** deprecated in 1.1 so I don't think we should say this. I understand that we want a place to put the information "Using health checks without setting the type will be deprecated in 2.0" and it's a problem that we haven't agreed on where but that's precisely what I hoped to disucss in https://lists.apache.org/thread.html/d9af817031efc6158540d8dee3402efeed821dcab2971f6138dc7db9@%3Cdev.mesos.apache.org%3E I'll follow up on this conversaion and propose changes to the versioning guide. src/health-check/health_checker.cpp (line 178) <https://reviews.apache.org/r/51560/#comment216097> This is not a direct translation of the versioning guide. How about ``` // TODO(haosdent): Remove this after the deprecation cycle which starts in 2.0. ``` src/health-check/health_checker.cpp (line 187) <https://reviews.apache.org/r/51560/#comment216158> I understand that we are not doing TCP for backwards compatibility but add a CHECK here? src/health-check/health_checker.cpp (line 188) <https://reviews.apache.org/r/51560/#comment216056> - s/didn't/is not/ - s/,/. - For the second sentence, how about `Use of 'HealthCheck' without specifying 'type' will be deprecated in Mesos 2.0`? - No trailing period. src/health-check/health_checker.cpp (line 620) <https://reviews.apache.org/r/51560/#comment216156> This is not a direct translation of the versioning guide. How about ``` // TODO(haosdent): Remove this after the deprecation cycle which starts in 2.0. ``` - Jiang Yan Xu On Sept. 12, 2016, 7:19 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51560/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 7:19 a.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and > Jiang Yan Xu. > > > Bugs: MESOS-6110 > https://issues.apache.org/jira/browse/MESOS-6110 > > > Repository: mesos > > > Description > ------- > > Health checks must supply set type field from now on. Additionally, > `HealthCheck.HTTP` message has been renamed to > `HealthCheck.HttpCheckInfo` to avoid naming collisions. > > > Diffs > ----- > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 > > Diff: https://reviews.apache.org/r/51560/diff/ > > > Testing > ------- > > Could verfied from > https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md > > > Thanks, > > haosdent huang > >
