----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51913/ -----------------------------------------------------------
(Updated Sept. 15, 2016, 1:40 p.m.) Review request for mesos, Benjamin Mahler and Vinod Kone. Changes ------- Tweak comments. Repository: mesos Description ------- If an agent attempts to register and is assigned an agent ID that already appears in the registry, the likely cause is a UUID collision: slave IDs are prefixed with master IDs, and master IDs are randomly generated UUIDs. UUID collisions are extremely unlikely, so in practice this should never happen. This commit updates the comments to clarify how unlikely this situation is. Furthermore, when it does happen, the master now just ignores the registration attempt, rather than trying to shutdown the agent. This is simpler; the agent will eventually try to register again and be assigned a new agent ID. Finally, it is unclear that shutting down the agent is actually appropriate: the previous coding added the duplicate ID to `slaves.removed`, which will interfere with the activity of the other slave whose ID we collided with. Diffs (updated) ----- src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 Diff: https://reviews.apache.org/r/51913/diff/ Testing ------- `make check` Thanks, Neil Conway
