----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ -----------------------------------------------------------
(Updated Sept. 18, 2016, 4:55 p.m.) Review request for mesos and Jiang Yan Xu. Changes ------- Refactored the original change into multiple RRs (see comments) and rebased. Bugs: MESOS-6062 https://issues.apache.org/jira/browse/MESOS-6062 Repository: mesos Description (updated) ------- When static resources indicate disks with a positive size, we use that for the disk resources on the agent. However, --resources can include disks with size of 0, which indicates that mesos agent determine the size of those disks from the host and uses that information instead. Note that this is not allowed for PATH disks since PATH disks can be carved into smaller chunks and we cannot assume that the whole physical disk is available to the PATH disk. With this change, JSON or textual representation for disk resources that specify scalar value of 0 would not result in an error, but those resources will not be accounted for until a valid size is determined for such resources. A scalar value of -1 in JSON or textual formats still results in an invalid resource. Diffs (updated) ----- src/slave/containerizer/containerizer.hpp f13669d0dfc4ce3287cfe630cabd0470dc765b51 src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c Diff: https://reviews.apache.org/r/51879/diff/ Testing ------- Tests passed. Thanks, Anindya Sinha