----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149390 -----------------------------------------------------------
src/cli/execute.cpp (lines 526 - 538) <https://reviews.apache.org/r/51978/#comment216993> I like to simplify the logic as: ``` if (volumes.isSome()) { foreach (const Volume& volume, volumes.get()) { containerInfo.add_volumes()->CopyFrom(volume); } } ``` src/cli/execute.cpp (line 544) <https://reviews.apache.org/r/51978/#comment216994> ``` volumes.isNone || volumes->empty() ``` src/cli/execute.cpp (line 778) <https://reviews.apache.org/r/51978/#comment216990> move this to L789 - Guangya Liu On 九月 18, 2016, 9:06 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51978/ > ----------------------------------------------------------- > > (Updated 九月 18, 2016, 9:06 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6096 > https://issues.apache.org/jira/browse/MESOS-6096 > > > Repository: mesos > > > Description > ------- > > This refactoring was needed for better accomodating pod support > for mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 > > Diff: https://reviews.apache.org/r/51978/diff/ > > > Testing > ------- > > Manually Ran: > mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" > --docker_image="ubuntu" --containerizer="docker" > > > Thanks, > > Abhishek Dasgupta > >
