----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52006/#review149410 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 534) <https://reviews.apache.org/r/52006/#comment217022> To be consistent with other messages, I think this should be `": It has child container "`. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 535) <https://reviews.apache.org/r/52006/#comment217020> I think this should be `" which is not cleaned up yet"` or `" not cleaned up yet"` - Qian Zhang On Sept. 19, 2016, 1:30 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52006/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 1:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6193 > https://issues.apache.org/jira/browse/MESOS-6193 > > > Repository: mesos > > > Description > ------- > > Supported docker/volume isolator to be nested aware. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > 2cc8e764ff18c95c29598df75cdb370ccf120662 > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > af9f3736b487b595e8768e56ce60dc4823db28a1 > > Diff: https://reviews.apache.org/r/52006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >