----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52025/#review149462 -----------------------------------------------------------
Patch looks great! Reviews applied: [52025] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 19, 2016, 10:19 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52025/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 10:19 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > `Process` is a CRTP class where we know that `T` is a valid derived > class. Also, it is customary to use `static_cast` when implementing > CRTP methods. > > This change uses a `static_cast` instead of a `dynamic_cast`; > `dynamic_cast` can result in a `nullptr` which should be checked. Here > this is not required, so `static_cast` is good enough for this use > case. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 54c7d2e7ed3923ab15ab86e36552b023f9de5215 > > Diff: https://reviews.apache.org/r/52025/diff/ > > > Testing > ------- > > make check (OS X, clang/trunk w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
