----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149505 -----------------------------------------------------------
Patch looks great! Reviews applied: [51784, 51930, 51931, 50271] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 19, 2016, 2:21 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50271/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 2:21 p.m.) > > > Review request for mesos, Jay Guo and Jie Yu. > > > Bugs: MESOS-5275 > https://issues.apache.org/jira/browse/MESOS-5275 > > > Repository: mesos > > > Description > ------- > > This isolator evaluates agent allowed capabilities and passes > net capabilities on to `mesos-containerizer` which enforces the > capabilities. > > Capability information is passed from the isolator via a new > capability field in `ContainerLaunchInfo`. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 20db010ea158a813034b411111ce9cddac7d8317 > src/CMakeLists.txt 42c52b60cc850901f2eff1545cf7900f4a65ca81 > src/Makefile.am 6fb095f58cf943c5597175df695046cfa21b68fd > src/slave/containerizer/mesos/containerizer.cpp > e54169ba00f6e0cdd7043075b4cdd12d714c99e3 > src/slave/containerizer/mesos/isolators/linux/capabilities.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.cpp > fc51e04ec1572679e6a48ff4f0fa31ef2dfd6ec3 > src/tests/containerizer/isolator_tests.cpp > 93ce75180520d382f63ce7323be844fe43c6594e > > Diff: https://reviews.apache.org/r/50271/diff/ > > > Testing > ------- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >