----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51984/#review149543 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Sept. 17, 2016, 8:25 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51984/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2016, 8:25 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > `std::atomic<T>` has a trivial default constructor, which means > `std::atomic` values are left uninitialized by default. `ProcessManager` > uses two atomic fields that are default-constructed; although we `store` > to them before reading from them, it would be cleaner and safer to > initialize them to a well-defined value in the first place. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 1e48fd5269d1a94c2217e8826af54b9b42ec4b23 > > Diff: https://reviews.apache.org/r/51984/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Neil Conway > >
