----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/#review149556 -----------------------------------------------------------
Bad patch! Reviews applied: [52042] Failed command: ./support/apply-review.sh -n -r 52042 Error: 2016-09-19 22:14:38 URL:https://reviews.apache.org/r/52042/diff/raw/ [1070/1070] -> "52042.patch" [1] Traceback (most recent call last): File "support/apply-reviews.py", line 342, in <module> reviewboard() File "support/apply-reviews.py", line 321, in reviewboard apply_review() File "support/apply-reviews.py", line 139, in apply_review commit_patch() File "support/apply-reviews.py", line 180, in commit_patch data = patch_data() File "support/apply-reviews.py", line 199, in patch_data return reviewboard_data() File "support/apply-reviews.py", line 258, in reviewboard_data review_url=url) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2026' in position 230: ordinal not in range(128) Full log: https://builds.apache.org/job/mesos-reviewbot/15320/console - Mesos ReviewBot On Sept. 19, 2016, 3:16 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52042/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 3:16 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > ------- > > If attempts to use the pailer to access sandboxes and/or mesos logs fail > because the user is unauthorized, an error telling the user he is > unauthorized is shown to the client instead of showing the misguiding > _Failed to initialize… retrying_. It also disables retry in case the > client is unauthorized. > > > Diffs > ----- > > src/webui/master/static/js/jquery.pailer.js > 79c3c0dad59c2dde78913116bb08383f7a6c4d5e > > Diff: https://reviews.apache.org/r/52042/diff/ > > > Testing > ------- > > `make check` > > and manual tests with the following ACLs > > ```json > { > "permissive": true, > "access_mesos_logs" : [ > { > "principals" : { "values" : ["foo"] }, > "logs" : { "type" : "NONE" } > } > ], > "access_sandboxes" : [ > { > "principals" : { "values" : ["foo"] }, > "users" : { "type" : "NONE" } > } > ] > } > > ``` > > and credentials: > > ``` > foo bar > baz bar > ``` > > > Thanks, > > Alexander Rojas > >
