-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149594
-----------------------------------------------------------




3rdparty/libprocess/src/openssl.cpp (line 289)
<https://reviews.apache.org/r/52033/#comment217248>

    Can you see if there is any other valuable information in the 
initialization routine that might be of value when a user posts a JIRA issue to 
help identify the code paths their system went through?
    Might be a good time to do a full review of the logging in this function 
rather than just up a few levels.
    
    You have been debugging many scenarios so I think you are in a unique 
position to do this!
    Thanks Till!



3rdparty/libprocess/src/openssl.cpp (line 446)
<https://reviews.apache.org/r/52033/#comment217243>

    Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 475)
<https://reviews.apache.org/r/52033/#comment217244>

    Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 478)
<https://reviews.apache.org/r/52033/#comment217245>

    Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 485)
<https://reviews.apache.org/r/52033/#comment217246>

    Why not this one?


- Joris Van Remoortere


On Sept. 19, 2016, 1:50 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
>     https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The logging messages in question prove to be very useful for debugging the
> cluster setup and hence we decided they should be generally available as their
> noise by far outwages their helpfulnes.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> -------
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Reply via email to