> On Sept. 20, 2016, 7:45 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3785 > > <https://reviews.apache.org/r/52055/diff/1/?file=1505453#file1505453line3785> > > > > Why need `recover` here? > > Vinod Kone wrote: > yea, can you add a comment on why you need to do a `recover` here?
Oh sorry I missed this, it's not necessary since I've seen other tests not do it, I had thought that the API contract was that recover will be called prior to other functions. I'll remove it. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52055/#review149617 ----------------------------------------------------------- On Sept. 20, 2016, 12:40 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52055/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 12:40 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This allows the caller to distinguish between a failure and waiting > on an unknown container. This is important for the upcoming agent > child container API, as the end-user would benefit from the > distinction. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > ef3c2ee22cf0ced35c64025c7f9f7ca75165d54d > src/slave/containerizer/composing.cpp > 5ff3e65facd5831e2637ae1cee3ea01b21d0f6b2 > src/slave/containerizer/containerizer.hpp > f13669d0dfc4ce3287cfe630cabd0470dc765b51 > src/slave/containerizer/docker.hpp a378fa9772742b4934578efcec54aeeaf5791a83 > src/slave/containerizer/docker.cpp 110a1eb41b1ff7cb94f3630a1843d9f01efbe09c > src/slave/containerizer/mesos/containerizer.hpp > 078ef4f4e7bf5e1522804a720c51cfa5518d8efd > src/slave/containerizer/mesos/containerizer.cpp > dc18e4e3b0eca3f116f1e240217bbebf64a75e3a > src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 > src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c > src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b > src/tests/containerizer.hpp f1fd57945c09fb80b7790f9124843a5d4ea785ee > src/tests/containerizer.cpp bda3e6f84f77a95f0eb9ff3aabdc9513f0f18b3f > src/tests/containerizer/composing_containerizer_tests.cpp > 51aab33cd190b53328339e39fd12853714882454 > src/tests/containerizer/docker_containerizer_tests.cpp > 28cd3fa66886dbdbae3fdeca77707147faafcb7a > src/tests/containerizer/filesystem_isolator_tests.cpp > df4642d2667407b1758ffe2efcfdbf9968cf2c33 > src/tests/containerizer/isolator_tests.cpp > 9bb1e69209f34b18b5b64c3daf5ea26780f2ab74 > src/tests/containerizer/mesos_containerizer_tests.cpp > 96e24500a12825161553eb050da389088b122695 > src/tests/containerizer/port_mapping_tests.cpp > 7fac6ca1550acf54616fb4cef2eab1335f5e9760 > src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 > src/tests/hook_tests.cpp d864ef3d6153dedab8cc47403b1b9f76d75aeb5c > src/tests/slave_recovery_tests.cpp d58d9bc0dbb0a60e114699485d1306202981ecf5 > > Diff: https://reviews.apache.org/r/52055/diff/ > > > Testing > ------- > > Added tests. > > make check > > > Thanks, > > Benjamin Mahler > >
