----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52415/#review151038 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/paths.cpp (lines 46 - 64) <https://reviews.apache.org/r/52415/#comment219161> I think the code is fine, but suggestion on simplifying: const string path = buildPath(containerId.parent(), separator, mode); switch (mode) { case PREFIX: case JOIN: return path::join(path, seperator, containerId.value()); case SUFFIX: return path::join(path, containerId.value(), separator); default: UNREACHABLE(); } - Benjamin Hindman On Sept. 30, 2016, 5:14 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52415/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 5:14 a.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Extended buildPath to support more modes. > > > Diffs > ----- > > src/Makefile.am f093000e0282a8d5ac17e7ba33711690ccdfe68a > src/slave/containerizer/mesos/linux_launcher.cpp > 1bce077e4aa97425b9cbdf8576a5dd52851c044e > src/slave/containerizer/mesos/paths.hpp > 1051c219c55253d03199045b6d2f43377ae93e53 > src/slave/containerizer/mesos/paths.cpp > 6c6b4dcc39fbc00485552caab88457918e622e08 > src/tests/containerizer/mesos_containerizer_paths_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52415/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
