----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52450/#review151107 -----------------------------------------------------------
src/slave/containerizer/mesos/paths.cpp (lines 50 - 52) <https://reviews.apache.org/r/52450/#comment219237> I would rather be explicit in the PREFIX case even though it's the same as the JOIN case. It's also a little confusing that above we have the order: ``` PREFIX SUFFIX JOIN ``` but here we have: ``` PREFIX JOIN SUFFIX ``` These should be in the same order (and mimic the order of the enum). - Kevin Klues On Sept. 30, 2016, 9:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52450/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 9:35 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > Simplied the buildPath logic. > > > Diffs > ----- > > src/slave/containerizer/mesos/paths.cpp > c34bd3340ca6507595e59fa3f87108eb6297a7ca > > Diff: https://reviews.apache.org/r/52450/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
