----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52466/#review151110 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Oct. 1, 2016, 1:21 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52466/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2016, 1:21 a.m.) > > > Review request for mesos, Benjamin Mahler and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > The return value of '_destroy' is not necessary. This patch also > addressed an issue where the destroy can be discarded if it gets a > discard from the caller since 'await' currently will transition the > returned future to DISCARDED (which should be fixed). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 9e834fd916ea86730e2406ce31440cf9ebc3ba9d > src/slave/containerizer/mesos/containerizer.cpp > fc53b4ebab89565205b3fdec53fc7c3d594e7db3 > > Diff: https://reviews.apache.org/r/52466/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
