----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/#review151269 -----------------------------------------------------------
src/examples/CMakeLists.txt (lines 142 - 154) <https://reviews.apache.org/r/49863/#comment219618> Can you double check if these `${EXAMPLES_LIBS}` are even necessary? Seems like something similar to my comments here: https://reviews.apache.org/r/50327/#comment219563 Check what is actually required to build these test modules. - Joseph Wu On Sept. 7, 2016, 11:33 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49863/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 11:33 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Builds shared libraries for dynamically loading them by various tests: > libexamplemodule, libtestauthorizer, libtestisolator, > libtestresource_estimator, libtestallocator, libtestcontainer_logger, > libtestmastercontender, libtestanonymous, libtesthook, > libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, > libtestqos_controller. > > > Diffs > ----- > > CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/49863/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
