----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52434/#review151494 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 680) <https://reviews.apache.org/r/52434/#comment219912> Note: we still need `os::mktemp`, because it creates the file, and the test expects the file to exist before starting the task. - Gastón Kleiman On Oct. 4, 2016, 4:14 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52434/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 4:14 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > The tmp file used in the HealthStatusChange test is now created inside > the tmp directory created for the test suite. This ensures that it will > be cleaned up on tear down. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52434/diff/ > > > Testing > ------- > > make check GTEST_FILTER="HealthCheckTest.*" V=0 > > > Thanks, > > Gastón Kleiman > >