----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/#review151501 -----------------------------------------------------------
src/tests/health_check_tests.cpp (lines 694 - 695) <https://reviews.apache.org/r/52433/#comment219923> For readability, let's wrap it like this: ``` const string healthCheckCmd = "rm " + tmpPath + " || (touch " + tmpPath + " && exit 1)"; ``` src/tests/health_check_tests.cpp (lines 707 - 709) <https://reviews.apache.org/r/52433/#comment219924> How about `statusHealthy`, `statusUnhealthy` and `statusHealthyAgain`? - Alexander Rukletsov On Sept. 30, 2016, 5:15 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52433/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 5:15 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > Improved the naming of variables in HealthCheckTest.HealthStatusChange. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52433/diff/ > > > Testing > ------- > > make check GTEST_FILTER="HealthCheckTest.*" V=0 > > > Thanks, > > Gastón Kleiman > >