----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/#review151263 -----------------------------------------------------------
LGTM as much as I understood. I'll defer to Joseph for the final ship it. src/cli_new/bin/config.py (lines 23 - 25) <https://reviews.apache.org/r/50912/#comment219775> reorder alphabetically src/cli_new/bin/config.py (line 50) <https://reviews.apache.org/r/50912/#comment219776> s/parse/open/ ? src/cli_new/bin/config.py (line 57) <https://reviews.apache.org/r/50912/#comment219777> s/json/JSON/ src/cli_new/bin/main.py (line 22) <https://reviews.apache.org/r/50912/#comment219778> why the space? also alphabetical ordering. src/cli_new/bin/main.py (line 87) <https://reviews.apache.org/r/50912/#comment219779> s/a/plugin/ src/cli_new/bootstrap (line 2) <https://reviews.apache.org/r/50912/#comment219597> Can you add a comment here about what this script does at a high level? src/cli_new/bootstrap (line 12) <https://reviews.apache.org/r/50912/#comment219773> I got confused between VIRTUALENV which represents its location and VIRTUAL_ENV below. maybe call this VIRTUALENV_PATH ? src/cli_new/bootstrap (line 19) <https://reviews.apache.org/r/50912/#comment219772> who sets VIRTUAL_ENV env variable? src/cli_new/mesos.bash_completion (line 5) <https://reviews.apache.org/r/50912/#comment219774> s/it/to it/ - Vinod Kone On Oct. 5, 2016, 4:12 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50912/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 4:12 a.m.) > > > Review request for mesos, Haris Choudhary and Joseph Wu. > > > Bugs: MESOS-6008 > https://issues.apache.org/jira/browse/MESOS-6008 > > > Repository: mesos > > > Description > ------- > > Added the infrastructure for a new python-based CLI. > > > Diffs > ----- > > src/cli_new/.gitignore PRE-CREATION > src/cli_new/README.md PRE-CREATION > src/cli_new/activate PRE-CREATION > src/cli_new/bin/config.py PRE-CREATION > src/cli_new/bin/main.py PRE-CREATION > src/cli_new/bin/mesos PRE-CREATION > src/cli_new/bootstrap PRE-CREATION > src/cli_new/deactivate PRE-CREATION > src/cli_new/lib/mesos/__init__.py PRE-CREATION > src/cli_new/lib/mesos/docopt.py PRE-CREATION > src/cli_new/lib/mesos/exceptions.py PRE-CREATION > src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION > src/cli_new/lib/mesos/plugins/base.py PRE-CREATION > src/cli_new/lib/mesos/util.py PRE-CREATION > src/cli_new/mesos.bash_completion PRE-CREATION > src/cli_new/pip-requirements.txt PRE-CREATION > src/cli_new/pylint.config PRE-CREATION > > Diff: https://reviews.apache.org/r/50912/diff/ > > > Testing > ------- > > $ cd src/cli_new > $ ./bootstrap > $ source activate > > (mesos-cli) $ mesos --help > > > Thanks, > > Kevin Klues > >
