----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review151891 -----------------------------------------------------------
Mostly looks great, although it would be nice if we could separate the sign comparison fixes from the other fixes. i.e., it would be good to have a single RR chain that enables `-Wsign-compare` for stout + fixes fallout; then `-Wsign-compare` for libprocess and fixes fallout; then `-Wall` for stout and fixes tests; and so on. (If I'm reading this correctly, we previously didn't enable basic stuff like `-Wall` for stout and libprocess?!). As noted in the other review, stout/libprocess/mesos changes should be split into separate reviews. - Neil Conway On Oct. 7, 2016, 7:22 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52647/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 7:22 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6239 > https://issues.apache.org/jira/browse/MESOS-6239 > > > Repository: mesos > > > Description > ------- > > The hardening flags produced many new warnings/errors that need to be fixed > for Mesos to compile/run. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/profiler.hpp f6fccfb > 3rdparty/libprocess/src/encoder.hpp af083d1 > 3rdparty/libprocess/src/process.cpp 02a1925 > 3rdparty/libprocess/src/profiler.cpp 0c4949e > 3rdparty/libprocess/src/socket.cpp 1e49518 > 3rdparty/libprocess/src/tests/benchmarks.cpp 945007c > 3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614 > 3rdparty/libprocess/src/tests/encoder_tests.cpp 9e57375 > 3rdparty/libprocess/src/tests/http_tests.cpp 2538f56 > 3rdparty/libprocess/src/tests/io_tests.cpp b85c79f > 3rdparty/libprocess/src/tests/process_tests.cpp b9feec7 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp 66ccff9 > 3rdparty/stout/tests/cache_tests.cpp 0950c85 > 3rdparty/stout/tests/flags_tests.cpp 94ba915 > 3rdparty/stout/tests/hashmap_tests.cpp 2626d67 > 3rdparty/stout/tests/hashset_tests.cpp 66e59db > 3rdparty/stout/tests/ip_tests.cpp 59e69a5 > 3rdparty/stout/tests/json_tests.cpp 2bc4c88 > 3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 > 3rdparty/stout/tests/multimap_tests.cpp 488991b > 3rdparty/stout/tests/os/process_tests.cpp 1e26877 > 3rdparty/stout/tests/os/sendfile_tests.cpp e221689 > 3rdparty/stout/tests/os/systems_tests.cpp 110ba5b > 3rdparty/stout/tests/os_tests.cpp c2900b8 > 3rdparty/stout/tests/strings_tests.cpp 7dd3301 > > Diff: https://reviews.apache.org/r/52647/diff/ > > > Testing > ------- > > Made sure compilation, tests, and benchmarks worked with both gcc and clang. > Ran `make && make check && make bench`. > > > Thanks, > > Aaron Wood > >
