----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152315 -----------------------------------------------------------
3rdparty/libprocess/Makefile.am (line 29) <https://reviews.apache.org/r/52695/#comment221282> Only use `-fstack-protector-strong` if we have GCC >= 4.9. - Aaron Wood On Oct. 11, 2016, 10:47 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52695/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 10:47 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > libprocess. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 020b0e1 > > Diff: https://reviews.apache.org/r/52695/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
