> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 17 > > <https://reviews.apache.org/r/52705/diff/1/?file=1529841#file1529841line17> > > > > How much work is it to do this now? If we're going to have a dedicated > > header, I would greatly prefer to put all the definitions in one place. > > Kevin Klues wrote: > See comment below for why it probably makes sense to just leave things as > they are for now
See comment below for rationale. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152196 ----------------------------------------------------------- On Oct. 10, 2016, 9:22 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52705/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 9:22 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6310 > https://issues.apache.org/jira/browse/MESOS-6310 > > > Repository: mesos > > > Description > ------- > > This was motivated by the need for a default definition of > 'W_EXITCODE' (since it is not technically POSIX compliant). > > > Diffs > ----- > > 3rdparty/stout/include/stout/wait.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52705/diff/ > > > Testing > ------- > > sudo GTEST_FILTER="*Nested*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
