----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review152478 -----------------------------------------------------------
Patch looks great! Reviews applied: [45962, 49571] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 13, 2016, 5:24 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49571/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 5:24 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5771 > https://issues.apache.org/jira/browse/MESOS-5771 > > > Repository: mesos > > > Description > ------- > > Allocations test has the following resource configurations: > (1) REGULAR: Offers from every slave have regular resources. > (2) SHARED: Offers from every slave include a shared resource. > (3) REGULAR: Offers from every alternate slave contain only regular > resources; and offers from every other alternate slave contains > a shared resource. > > This test is parameterized based on number of agents, number of > frameworks and resource configuration. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 46553f6d501deb37862dd5ba48be1c114f6e6cb8 > > Diff: https://reviews.apache.org/r/49571/diff/ > > > Testing > ------- > > All tests passed. > > Allocations benchmark test results > ================================== > Support of shared resources has a small impact (roughly 10%) on runtime > performance in allocations as compared to HEAD (without shared resources). > Also, there is no visible impact in performance when shared resources are > added in the tests. > > Following is a snapshot with 1000 agents and 200 frameworks. > > With the patch (and no shared resources) > ---------------------------------------- > [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9 > Using 1000 agents and 200 frameworks with resource type 0 > Added 200 frameworks in 6907us > Added 1000 agents in 2.057098secs > round 0 allocate() took 1.689164secs to make 1000 offers > round 50 allocate() took 1.672373secs to make 1000 offers > round 100 allocate() took 1.680571secs to make 1000 offers > round 150 allocate() took 1.674683secs to make 1000 offers > round 199 allocate() took 1.671525secs to make 1000 offers > > With the patch (and shared resources on all agents) > --------------------------------------------------- > [ RUN ] > AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10 > Using 1000 agents and 200 frameworks with resource type 1 > Added 200 frameworks in 6888us > Added 1000 agents in 2.096218secs > round 0 allocate() took 1.704491secs to make 1000 offers > round 50 allocate() took 1.718623secs to make 1000 offers > round 100 allocate() took 1.716224secs to make 1000 offers > round 150 allocate() took 1.707343secs to make 1000 offers > round 199 allocate() took 1.727467secs to make 1000 offers > > With the patch (and shared resources on alternate agents) > --------------------------------------------------------- > [ RUN ] > AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11 > Using 1000 agents and 200 frameworks with resource type 2 > Added 200 frameworks in 7304us > Added 1000 agents in 2.071009secs > round 0 allocate() took 1.689045secs to make 1000 offers > round 50 allocate() took 1.691524secs to make 1000 offers > round 100 allocate() took 1.688873secs to make 1000 offers > round 150 allocate() took 1.688713secs to make 1000 offers > round 199 allocate() took 1.691223secs to make 1000 offers > > Based on HEAD, with all regular resources (no shared resources in HEAD > supported) > --------------------------------------------------------------------------------- > [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9 > Using 1000 agents and 200 frameworks with resource type 0 > Added 200 frameworks in 6801us > Added 1000 agents in 1.721447secs > round 0 allocate() took 1.502953secs to make 1000 offers > round 50 allocate() took 1.520157secs to make 1000 offers > round 100 allocate() took 1.517221secs to make 1000 offers > round 150 allocate() took 1.526446secs to make 1000 offers > round 199 allocate() took 1.538005secs to make 1000 offers > > > Thanks, > > Anindya Sinha > >
