----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review152507 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 1679) <https://reviews.apache.org/r/52251/#comment221516> This test is flaky, because the master will sometimes not listen on 127.0.0.1. I think that this test should use `nc` like the Docker tests. - Gastón Kleiman On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52251/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:37 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6279 > https://issues.apache.org/jira/browse/MESOS-6279 > > > Repository: mesos > > > Description > ------- > > Added test cases for TCP health check. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52251/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
