----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review152553 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 1516) <https://reviews.apache.org/r/52250/#comment221595> Hi, @gaston Good point! It is flaky as you said. We could test it via `nc` but `nc` is flaky as well when @alexr test `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`. So I add [a test helper](https://reviews.apache.org/r/52786/) to our health check test cases don't depends on `nc`. But another simple solution is we make `agent` bind to `0.0.0.0` as this email said http://search-hadoop.com/m/0Vlr6SPE4d1hepk5 - haosdent huang On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52250/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:37 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6278 > https://issues.apache.org/jira/browse/MESOS-6278 > > > Repository: mesos > > > Description > ------- > > Added test cases for HTTP health check. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52250/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
