----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52901/#review152759 -----------------------------------------------------------
Fix it, then Ship it! CHANGELOG (lines 5 - 10) <https://reviews.apache.org/r/52901/#comment221858> It would be nice to distinguish the nested container support and the task group support in the changelog, i.e. we include nested container support for executors / operators to launch nested containers within an executor's container, and if you launch a task group using the default executor it will use a nested container for each task (using the new support for it). CHANGELOG (line 7) <https://reviews.apache.org/r/52901/#comment221852> "all or none of the tasks in the group" ? docs/app-framework-development-guide.md (lines 18 - 24) <https://reviews.apache.org/r/52901/#comment221859> Is this related or did you want to pull this out into a separate commit? docs/app-framework-development-guide.md (line 329) <https://reviews.apache.org/r/52901/#comment221862> Not the freezer though.. right? Should we tell them about the cgroup level detail here or do they just need to know about the visible isolation semantics and namespaces? docs/app-framework-development-guide.md (line 335) <https://reviews.apache.org/r/52901/#comment221863> Do we want to call out that the other namespaces are not shared? docs/app-framework-development-guide.md (lines 364 - 370) <https://reviews.apache.org/r/52901/#comment221861> Related? docs/scheduler-http-api.md (line 275) <https://reviews.apache.org/r/52901/#comment221860> A little muddled? - Benjamin Mahler On Oct. 14, 2016, 10:15 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52901/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 10:15 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This is very minimal documentation mainly around the new framework > APIs and the default executor. > > > Diffs > ----- > > CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4 > docs/app-framework-development-guide.md > 84521cdf32e75599988e55f5f50e94b032eed62f > docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 > docs/scheduler-http-api.md a27965abac1263542f0711d997804c0bcec5a716 > > Diff: https://reviews.apache.org/r/52901/diff/ > > > Testing > ------- > > > Thanks, > > Vinod Kone > >
