----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review152830 -----------------------------------------------------------
src/health-check/health_checker.cpp (lines 356 - 357) <https://reviews.apache.org/r/52867/#comment221954> Is it possible to use `checkTimeout` here directly? - haosdent huang On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52867/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 3:26 p.m.) > > > Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and > Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Additionally persist health check parameters from the `HealthCheck` > protobuf as class members to avoid code duplication. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > > Diff: https://reviews.apache.org/r/52867/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >