> On Oct. 17, 2016, 11:30 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1507-1508 > > <https://reviews.apache.org/r/52771/diff/1/?file=1532090#file1532090line1507> > > > > Looks like CNI spec does not specify if stdout will be empty or not. > > Let's just print all of them like you did in the attach code.
Agreed. Actually in case of an error, the CNI error is going to be thrown in the stdout, so should capturing stdout as well. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review152988 ----------------------------------------------------------- On Oct. 12, 2016, 6:27 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52771/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 6:27 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6282 > https://issues.apache.org/jira/browse/MESOS-6282 > > > Repository: mesos > > > Description > ------- > > Till now we were capturing only the `stdout` of the CNI plugin. However, > during errors it makes sense to add the output from `stderr` for the > CNI plugin as well, since as per the CNI spec the CNI plugin is > supposed to output all unstructured output (debugs for example) to > `stderr`. This greatly helps in debugging the exact reason for CNI > plugin failures. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 70f30831819d7a0e6233fcb13a703dc6981324b6 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1b22b28825e8160f659c3cbac37cc576f01666d5 > > Diff: https://reviews.apache.org/r/52771/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
