----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53009/#review153243 -----------------------------------------------------------
Ship it! LGTM src/examples/no_executor_framework.cpp (lines 127 - 137) <https://reviews.apache.org/r/53009/#comment222526> Since currently task labels are simply copied into `TaskInfo` they can be baked into `Labels` outside of `NoExecutorScheduler`. But here this is more a style preference, feel free to drop. - Ilya Pronin On Oct. 19, 2016, 2:07 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53009/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 2:07 a.m.) > > > Review request for mesos, Benjamin Mahler and Ilya Pronin. > > > Repository: mesos > > > Description > ------- > > Add support for task labels to example no_executor_framework. > > > Diffs > ----- > > src/examples/no_executor_framework.cpp > e82ae9a9ea23c7d181b071f0e3f5071b3856d8a4 > > Diff: https://reviews.apache.org/r/53009/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
