----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review153345 -----------------------------------------------------------
Jacob, regaring the test failure of `OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable`, I think that you can disable it as `DISABLED_RescindRevocableOfferWithIncreasedRevocable` in your patch, and I will fix this in /r/51621 I found that with current logic, it is difficult to handle this case, as we cannot make sure the complete order for `allocator->updateSlave` and `allocator->recoverResources`, if `allocator->recoverResources` finished first, then the offer will have `3 REV resources`; if `allocator->updateSlave` finished first, then the offer will have `2 REV resources`. With /r/51621 , after we enable `recoverResources` allocate resources, we can always make sure we get `3 REV resources` in the offer, so I propose that you disable the test case first and I will fix this after we enable allocate resources when `recoverResoures`. - Guangya Liu On 十月 18, 2016, 4:14 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated 十月 18, 2016, 4:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check > > note: check without filters depends on https://reviews.apache.org/r/51028 and > https://reviews.apache.org/r/52534 > > > Thanks, > > Jacob Janco > >
