----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53055/ -----------------------------------------------------------
Review request for mesos, Michael Park and Till Toenshoff. Bugs: MESOS-6424 https://issues.apache.org/jira/browse/MESOS-6424 Repository: mesos Description ------- We checked here whether the passed pointer is not null, while we in fact wanted to confirm that the performed dynamic_cast succeeded (like is already done e.g., in the definitions of flags.stringify or flags.validate). This change makes us check the result of the dynamic_cast like originally intended. Diffs ----- 3rdparty/stout/include/stout/flags/flags.hpp 15446de795a620e9759faf3a552c234dc739fa3f Diff: https://reviews.apache.org/r/53055/diff/ Testing ------- * make check (OS X, clang-trunk w/o optimizations) * tested on a number of Linux setups in internal CI Thanks, Benjamin Bannier