----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/#review153420 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 361 - 382) <https://reviews.apache.org/r/53053/#comment222724> If I understand this correctly, for directories AUFS relies on the `WHITEOUT_OPAQUE_PREFIX` file to remove directories between layers and regular whiteout files for removing files, whereas overlayfs relies on setting attributes (trusted.overlay.opaque) on the directory to remove them between layers and requires a character device file of ID 0 for removing reqular files. Would be great to capture this logic in a comment here with citations to the overlayfs documentation https://www.kernel.org/doc/Documentation/filesystems/overlayfs.txt and the AUFS documentation. - Avinash sridharan On Oct. 20, 2016, 1:53 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53053/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 1:53 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > > Diff: https://reviews.apache.org/r/53053/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
