----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53062/#review153441 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp (line 45) <https://reviews.apache.org/r/53062/#comment222758> Let's wrap this with ifndef WINDOWS src/slave/containerizer/mesos/launch.cpp (line 105) <https://reviews.apache.org/r/53062/#comment222759> That makes me think if we should make 'unlimited' be more explicit. With the current scheme, unlimited of RLIMIT_FSIZE will be represented as: ``` '{"rlimits":[{"type":"RLMT_FSIZE"}]}' ``` I am wondering if we should introduce an optional `unlimited` field: ``` message RLimit { optional Type type = 1; optional uint64_t soft = 2; optional uint64_t hard = 3; optional bool unlimited = 4; } '{"rlimits":[{"type":"RLMT_FSIZE","unlimited":true}]}' ``` src/slave/containerizer/mesos/launch.cpp (lines 591 - 602) <https://reviews.apache.org/r/53062/#comment222760> This won't work because data services explicitly want to get limit above what's configured. - Jie Yu On Oct. 20, 2016, 4:33 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53062/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 4:33 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6426 > https://issues.apache.org/jira/browse/MESOS-6426 > > > Repository: mesos > > > Description > ------- > > This commit adds a new launch flag `--rlimits` which can be used to > specify POSIX resource limits for the container. The resource limits > are set as the user, so to increase resource limits beyond configured > system limits additional priviledges might be needed. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.hpp > f8bac0650965a49562b9910bf6140ded8dbb69ac > src/slave/containerizer/mesos/launch.cpp > 4a41aaf103f5a9bc6f7a798f63f491fc7cf11f7e > > Diff: https://reviews.apache.org/r/53062/diff/ > > > Testing > ------- > > Tested as part of https://reviews.apache.org/r/53061/. > > > Thanks, > > Benjamin Bannier > >
