----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153393 -----------------------------------------------------------
3rdparty/stout/include/stout/os/posix/xattr.hpp (line 24) <https://reviews.apache.org/r/53041/#comment222687> Can you elaborate on `stout-specific versions`? Did you mean we define two versions of `setxattr()` here, one for Linux and another for APPLE? 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 51) <https://reviews.apache.org/r/53041/#comment222689> Did you mean if caller passes `XATTR_NOFOLLOW` as flag to this method on Linux, internally we call `lgetxattr()`? But I think it may confuse the caller since on Linux `getxattr()` does not support flags at all, so I would suggest not to mix `getxattr()` and `lgetxattr()` in one method. 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 64) <https://reviews.apache.org/r/53041/#comment222873> Can you please let me know the advantage of `std::vector<char>`? To me, `new` + `memset` can satisfy my requirement here. 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 80) <https://reviews.apache.org/r/53041/#comment222864> Agree! 3rdparty/stout/include/stout/os/xattr.hpp (line 21) <https://reviews.apache.org/r/53041/#comment222857> Yes, I agree, let me mark those functions as delete on Windows. - Qian Zhang On Oct. 20, 2016, 11:20 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53041/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 11:20 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > Added `setxattr()` and `getxattr()` in stout. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f > 3rdparty/stout/include/stout/os.hpp > 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 > 3rdparty/stout/include/stout/os/posix/xattr.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/xattr.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/xattr.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53041/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
