> On Oct. 24, 2016, 6 p.m., James Peach wrote: > > 3rdparty/libprocess/src/profiler.cpp, line 35 > > <https://reviews.apache.org/r/52754/diff/1/?file=1531401#file1531401line35> > > > > Why remove this? It looks like it is actually used?
You're right, it does look like it's used. Without removing it I get: ``` ../../../3rdparty/libprocess/src/profiler.cpp:35:12: error: unused variable 'PROFILE_FILE' [-Werror,-Wunused-const-variable] const char PROFILE_FILE[] = "perftools.out"; ``` I get the same error if I take it out of the unnamed namespace. I don't see it defined anywhere else in the codebase. Is it coming from some third party source...? - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/#review153715 ----------------------------------------------------------- On Oct. 21, 2016, 6:31 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52754/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 6:31 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6239 > https://issues.apache.org/jira/browse/MESOS-6239 > > > Repository: mesos > > > Description > ------- > > The hardening flags produced many new errors about unused functions, > variables, etc. that need to be fixed for Mesos to compile/run. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/profiler.hpp f6fccfb > 3rdparty/libprocess/src/profiler.cpp 0c4949e > 3rdparty/libprocess/src/tests/benchmarks.cpp 945007c > 3rdparty/libprocess/src/tests/process_tests.cpp 3936f47 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf > > Diff: https://reviews.apache.org/r/52754/diff/ > > > Testing > ------- > > Made sure compilation, tests, and benchmarks worked with both gcc and clang. > Ran make && make check && make bench. > > > Thanks, > > Aaron Wood > >
