> On Oct. 2, 2016, 3:14 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2182 > > <https://reviews.apache.org/r/52002/diff/6/?file=1513455#file1513455line2182> > > > > Here we should keep 4 space start from the `(` above or else you can: > > > > ``` > > ASSERT_TRUE( > > Resources::isRootDisk( > > createDiskResource("100", "role1", None(), None()))); > > ``` > > > > Ditto for others which has two `(` in one line. > > Anindya Sinha wrote: > Can you point to the specific style from the style guide > (http://mesos.apache.org/documentation/latest/c++-style-guide/) which is > being violated here? > I agree your option would satisfy the style guide but am curious why do > you think the current version violates it. AFAICT, there is no specific rule > for 2 "(" in the same line. > > Guangya Liu wrote: > I did not found this in C++ style, but in a review here > https://reviews.apache.org/r/52020/
I think I would leave it the way it is since there are numerous places where this pattern is used. As one example: https://github.com/apache/mesos/blob/master/src/tests/persistent_volume_tests.cpp#L539-L541 - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review151126 ----------------------------------------------------------- On Oct. 6, 2016, 2 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52002/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 2 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Added helper methods to determine types of disk resources. > > > Diffs > ----- > > include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 > include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 > src/common/resources.cpp 0774ff0669e831494d5b12b88e19dfa0a4a3f757 > src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a > src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90 > > Diff: https://reviews.apache.org/r/52002/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
