----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review153843 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 149 - 151) <https://reviews.apache.org/r/50947/#comment223350> Can we cahge the order of these conditionals: i.e. change: ``` if (strings::contains(flags.containerizers, "mesos") && flags.nvidia_gpu_devices.isSome() && isolators.count("gpu/nvidia") == 0) { ``` to: ``` if (strings::contains(flags.containerizers, "mesos") && isolators.count("gpu/nvidia") == 0 && flags.nvidia_gpu_devices.isSome()) { ``` - Kevin Klues On Oct. 24, 2016, 5:07 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50947/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 5:07 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while > docker and external containerizers do not need it anymore. This removed > the 'gpu/nvidia' isolator check for docker and external containerizers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > 2e722691475c84afae14009014ea70cc0fdd0e65 > > Diff: https://reviews.apache.org/r/50947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
