----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153988 -----------------------------------------------------------
Patch looks great! Reviews applied: [53193, 53172] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 27, 2016, 4:54 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53172/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 4:54 a.m.) > > > Review request for mesos, Joseph Wu, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6446 > https://issues.apache.org/jira/browse/MESOS-6446 > > > Repository: mesos > > > Description > ------- > > After introduced redirection on `/master/state` endpoint to the leading > master in `c9153336`, the manual redirection logic in WebUI in broken > because browser would redirect requests automatically when receives > `307 Temporary Redirect`. Because the metrics information for tasks is > only available on the leading master, it would miss in WebUI if the > master we accessed is not a leading master. In this patch, we retrieve > the leading master from `/master/state` endpoint and ensure the > requests to `/metrics/snapshot` endpoint always send to the leading > master. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > 3dead4f20e2dbeec8447e22ad287dd6ed2378345 > > Diff: https://reviews.apache.org/r/53172/diff/ > > > Testing > ------- > > ... > > > Test screen record. > >  > > > Thanks, > > haosdent huang > >
